refinement

Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
oras-project · Sep 18, 2024 · 70fc421 · 70fc421
1 parent 9ea1f26
commit 70fc421
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/cmd/oras/root/manifest/index/create.go b/cmd/oras/root/manifest/index/create.go
@@ -224,6 +224,9 @@ func parseAnnotations(input []string) (map[string]string, error) {
 		if !success {
 			return nil, fmt.Errorf("annotation value doesn't match the required format of \"key=value\"")
 		}
+		if _, ok := annotations[key]; ok {
+			return nil, fmt.Errorf("duplicate annotation key: %v", key)
+		}
 		annotations[key] = val
 	}
 	return annotations, nil

diff --git a/cmd/oras/root/manifest/index/create_test.go b/cmd/oras/root/manifest/index/create_test.go
@@ -40,6 +40,12 @@ func Test_parseAnnotations(t *testing.T) {
 			wantErr:         true,
 			wantAnnotations: nil,
 		},
+		{
+			name:            "duplicate key",
+			input:           []string{"a=b", "c=d", "a=e"},
+			wantErr:         true,
+			wantAnnotations: nil,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {