Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message when no tag or digest provided #1211

Closed
Tracked by #1218
qweeah opened this issue Dec 26, 2023 · 2 comments · Fixed by #1234
Closed
Tracked by #1218

improve error message when no tag or digest provided #1211

qweeah opened this issue Dec 26, 2023 · 2 comments · Fixed by #1234
Assignees
Labels
ux User experience related
Milestone

Comments

@qweeah
Copy link
Contributor

qweeah commented Dec 26, 2023

Current behavior and output:

$ oras manifest fetch --oci-layout /tmp/ginkgo1163328512
Error: "/tmp/ginkgo1163328512": no tag or digest when expecting <name:tag|name@digest>

Suggested error message:

$ oras manifest fetch --oci-layout /tmp/ginkgo1163328512
Error: "/tmp/ginkgo1163328512": no tag or digest specified
Usage: oras manifest fetch [flags] <name>{:<tag>|@<digest>}
You need to specify an artifact reference in the form of "<name>:<tag>" or "<name>@<digest>". Run "oras manifest fetch -h" for more options and examples 
@qweeah qweeah added the ux User experience related label Dec 26, 2023
@qweeah qweeah mentioned this issue Dec 26, 2023
9 tasks
@qweeah qweeah added this to the v1.2.0 milestone Dec 26, 2023
@wangxiaoxuan273
Copy link
Contributor

I would like to work on this issue.

@qweeah qweeah changed the title improve error message when no tag or digest provided when fetching a manifest improve error message when no tag or digest provided Jan 8, 2024
@qweeah
Copy link
Contributor Author

qweeah commented Jan 8, 2024

This change can also be applied to

  • oras attach
  • oras cp
  • oras discover
  • oras pull
  • oras resolve
  • oras delete
  • oras tag
  • oras manifest delete
  • oras blob delete (please be aware that there is not tag in the hint)
  • oras manifest fetch-config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux User experience related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants