-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ux): improve error message for oras manifest fetch #1234
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1234 +/- ##
==========================================
+ Coverage 81.08% 81.44% +0.35%
==========================================
Files 67 67
Lines 3727 3740 +13
==========================================
+ Hits 3022 3046 +24
+ Misses 494 486 -8
+ Partials 211 208 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor suggestion.
I just merged another PR, @wangxiaoxuan273 can you help resolve the conflicts? |
47606e3
to
fdbc3e9
Compare
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
fdbc3e9
to
9857173
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…t#1234) Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com> Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
What this PR does / why we need it:
improve error message for oras manifest fetch
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1211 and #1233
Please check the following list:
Current display: