Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ux): improve error message for oras manifest fetch #1234

Merged
merged 1 commit into from
Jan 16, 2024
Merged

chore(ux): improve error message for oras manifest fetch #1234

merged 1 commit into from
Jan 16, 2024

Conversation

wangxiaoxuan273
Copy link
Contributor

@wangxiaoxuan273 wangxiaoxuan273 commented Jan 8, 2024 •
edited
Loading

What this PR does / why we need it:

improve error message for oras manifest fetch

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1211 and #1233

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Current display:
image

@codecov Codecov
Copy link

codecov bot commented Jan 8, 2024 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5bb6c76) 81.08% compared to head (9857173) 81.44%.

Files Patch % Lines
cmd/oras/root/attach.go 75.00% 0 Missing and 1 partial ⚠️
cmd/oras/root/pull.go 75.00% 0 Missing and 1 partial ⚠️
cmd/oras/root/tag.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1234      +/-   ##
==========================================
+ Coverage   81.08%   81.44%   +0.35%     
==========================================
  Files          67       67              
  Lines        3727     3740      +13     
==========================================
+ Hits         3022     3046      +24     
+ Misses        494      486       -8     
+ Partials      211      208       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qweeah
qweeah requested changes Jan 12, 2024
View reviewed changes
cmd/oras/internal/errors/errors.go Outdated Show resolved Hide resolved
qweeah
qweeah approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor suggestion.

@qweeah
Copy link
Contributor

qweeah commented Jan 16, 2024

I just merged another PR, @wangxiaoxuan273 can you help resolve the conflicts?

@wangxiaoxuan273
chore(ux): improve error msg
9857173 
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
shizhMSFT
shizhMSFT approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit bbe42fd into oras-project:main Jan 16, 2024
8 checks passed
@wangxiaoxuan273 wangxiaoxuan273 deleted the manifest-fetch branch January 19, 2024 09:12
@qweeah qweeah mentioned this pull request Feb 1, 2024
Merged
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
@wangxiaoxuan273 @FeynmanZhou
chore(ux): improve error message for oras manifest fetch (oras-projec…
1956674 
…t#1234)

Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qweeah qweeah qweeah approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

@TerryHowe TerryHowe Awaiting requested review from TerryHowe TerryHowe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve error message when no tag or digest provided
3 participants
@wangxiaoxuan273 @qweeah @shizhMSFT