Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: add test specs for oras pull command #567

Closed
Tracked by #563
qweeah opened this issue Sep 15, 2022 · 1 comment · Fixed by #693
Closed
Tracked by #563

e2e: add test specs for oras pull command #567

qweeah opened this issue Sep 15, 2022 · 1 comment · Fixed by #693
Assignees
@qweeah
Labels
E2E testing End-to-end testing related issues or pull requests
Milestone
v1.0.0-rc.1

Comments

@qweeah
Copy link
Contributor

qweeah commented Sep 15, 2022 •
edited
Loading

Happy paths:

  • should pull all files in an image to a target folder
  • should also pull config file with --config option
  • should pull specific platform with --platform option

should show correct pull status for all the pulling

Bad paths:

  • should fail if path traversal is needed but not enabled
  • should fail if file overwrite is needed but not enabled
  • should fail directly if not logged in
  • should fail if no artifact reference provided
@qweeah qweeah mentioned this issue Sep 15, 2022
Closed
4 tasks
@qweeah qweeah added the E2E testing End-to-end testing related issues or pull requests label Sep 16, 2022
@shizhMSFT shizhMSFT added this to the v0.16.0 milestone Sep 17, 2022
@qweeah qweeah modified the milestones: v0.16.0, v0.17.0 Nov 2, 2022
@qweeah qweeah mentioned this issue Nov 17, 2022
Merged
@qweeah
Copy link
Contributor Author

qweeah commented Nov 17, 2022

Will skip should fail if file overwrite is needed but not enabled since it should be covered by oras-go file target unit tests.

@qweeah qweeah self-assigned this Nov 23, 2022
shizhMSFT pushed a commit that referenced this issue Dec 14, 2022
@qweeah
test: add e2e specs for oras pull (#693)
239e145 
Resolves: #567
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@shizhMSFT shizhMSFT moved this to Done in ORAS-Planning Dec 14, 2022
@FeynmanZhou FeynmanZhou modified the milestones: v0.16.1, v1.0.0-rc.1 Jan 3, 2023
TerryHowe pushed a commit to TerryHowe/oras that referenced this issue Feb 2, 2023
@qweeah
test: add e2e specs for oras pull (oras-project#693)
1bca604 
Resolves: oras-project#567
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qweeah qweeah

Labels
E2E testing End-to-end testing related issues or pull requests
Projects
No open projects
ORAS-Planning
Status: Done
Milestone
v1.0.0-rc.1
Development

Successfully merging a pull request may close this issue.

test: add e2e specs for oras pull qweeah/oras
3 participants
@qweeah @shizhMSFT @FeynmanZhou