Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: wrt zot since v0.16.0? #719

Closed
1 task
rchincha opened this issue Dec 9, 2022 · 1 comment · Fixed by #715
Closed
1 task

regression: wrt zot since v0.16.0? #719

rchincha opened this issue Dec 9, 2022 · 1 comment · Fixed by #715
Labels
bug Something isn't working

Comments

@rchincha
Copy link

rchincha commented Dec 9, 2022

What happened in your environment?

In context of #709, trying to figure out what broke.

Looks like a regression at 2329c6e.

First skopeo copy busybox:latest image into zot, then

With oras v0.16.0

$ORAS_PATH attach --plain-http $ORAS_REGISTRY_HOST/busybox:latest --artifact-type 'signature/example' ./signature.json:application/json
Exists    8a865c9da82b signature.json
Attached to localhost:8080/busybox@sha256:67bb7f36fcda428c491d7aa9a24ec0f1a8f6cdf472ef2c827ec7b6c2e36207f2
Digest: sha256:4e23167b9a8d41e8e95f51536b7333371fbf7b6bd993a9acc422a729150a9e90

With oras 2329c6e, see this error.

$ORAS_PATH attach --plain-http $ORAS_REGISTRY_HOST/busybox:latest --artifact-type 'signature/example' ./signature.json:application/json
Exists    8a865c9da82b signature.json
Error: sha256:efa88158fbb53aab65044fd2ec001fb855344a881461a1bf6171068eef4cee64: application/vnd.oci.artifact.manifest.v1+json: not found

What did you expect to happen?

No response

How can we reproduce it?

Pls see above.

What is the version of your ORAS CLI?

2329c6e

What is your OS environment?

ubuntu 22.04

Are you willing to submit PRs to fix it?

  • Yes, I am willing to fix it.
@qweeah
Copy link
Contributor

qweeah commented Dec 10, 2022

@rchincha Thanks a lot for investigating this issue. After taking a close look, this regression was introduced from oras-go library in oras-project/oras-go#359.

The manifest was packed into the file store, oras-go created a cache but the packed manifest was not cache. Should check whether the cache contains the descriptor in here.

cc oras-go maintainer @Wwwsylvia @shizhMSFT for tracking this issue in oras-go.

shizhMSFT pushed a commit that referenced this issue Dec 14, 2022
To accommodate the latest breaking change in oras-go rc6.

Resolves #719 

Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
TerryHowe pushed a commit to TerryHowe/oras that referenced this issue Feb 2, 2023
…-project#715)

To accommodate the latest breaking change in oras-go rc6.

Resolves oras-project#719 

Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants