Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update container build prepare job output in Github Actions #1019

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Jul 11, 2023

What this PR does / why we need it:
This PR removes the usage of set-output in Github Actions. Tested in my own fork and it works as expected: https://github.com/qweeah/oras/actions/runs/5521156830/jobs/10068846025

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1018

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1019 (08b908d) into main (46780e7) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #1019   +/-   ##
=======================================
  Coverage   81.04%   81.04%           
=======================================
  Files          57       57           
  Lines        2907     2907           
=======================================
  Hits         2356     2356           
  Misses        376      376           
  Partials      175      175           

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit ed3fbcc into oras-project:main Jul 12, 2023
qweeah added a commit to qweeah/oras that referenced this pull request Jul 21, 2023
qweeah added a commit to qweeah/oras that referenced this pull request Jul 21, 2023
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update github actions configuration
4 participants