Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make error returned by oras tag more readable #1058

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Aug 9, 2023

This PR improves the readability of error info when an invalid reference is provided:

$ oras tag list test
Error: unable to add tag for 'list': invalid reference: missing repository

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Merging #1058 (52c7559) into main (dcc112b) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1058      +/-   ##
==========================================
+ Coverage   81.25%   81.33%   +0.08%     
==========================================
  Files          57       57              
  Lines        2912     2914       +2     
==========================================
+ Hits         2366     2370       +4     
+ Misses        373      371       -2     
  Partials      173      173              
Files Changed Coverage Δ
cmd/oras/root/tag.go 89.09% <100.00%> (+0.41%) ⬆️

... and 1 file with indirect coverage changes

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit ceb56f8 into oras-project:main Aug 9, 2023
6 checks passed
@qweeah qweeah deleted the tag-ux branch August 9, 2023 03:50
@qweeah qweeah mentioned this pull request Mar 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants