fix: avoid copy suggestion when only config is skipped #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
sajayantony
requested review from
shizhMSFT,
SteveLasker,
qweeah and
TerryHowe
as code owners
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #1164 +/- ##
==========================================
- Coverage 79.94% 79.89% -0.05%
==========================================
Files 65 65
Lines 3520 3547 +27
==========================================
+ Hits 2814 2834 +20
- Misses 492 496 +4
- Partials 214 217 +3
|
qweeah
reviewed
Nov 3, 2023
qweeah
reviewed
Nov 3, 2023
Co-authored-by: Billy Zha <qweeah@gmail.com> Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Wwwsylvia
reviewed
Nov 3, 2023
shizhMSFT
reviewed
Nov 3, 2023
shizhMSFT
reviewed
Nov 3, 2023
shizhMSFT
reviewed
Nov 3, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
added a commit
to qweeah/oras
that referenced
this pull request
Nov 4, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
added a commit
that referenced
this pull request
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The recommendation to use ORAS copy will be skipped if the only layer not downloaded is the config.
When we try to download an image
When there is an artifact with one layer and only empty config is skipped -