-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump github.com/spf13/cobra from 1.7.0 to 1.8.0 #1171
build(deps): bump github.com/spf13/cobra from 1.7.0 to 1.8.0 #1171
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #1171 +/- ##
=======================================
Coverage ? 80.03%
=======================================
Files ? 65
Lines ? 3551
Branches ? 0
=======================================
Hits ? 2842
Misses ? 494
Partials ? 215 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Worth noticing that a new function, Command.ErrPrefix, is introduced to setup error prefix (previously the error prefix is always Error:
). We can utilize this function to customize ORAS' error message if needed @FeynmanZhou @shizhMSFT @sajayantony.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@qweeah Nice call out. One thing I can think about Command.SetErrPrefix is to have Error:
in different languages. e.g. 错误:
, エラー:
, ❌
.
e88f92d
to
761af3e
Compare
@dependabot rebase |
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.7.0 to 1.8.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.7.0...v1.8.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
761af3e
to
f85565e
Compare
Bumps github.com/spf13/cobra from 1.7.0 to 1.8.0.
Release notes
Sourced from github.com/spf13/cobra's releases.
Commits
a0a6ae0
Improve API to get flag completion function (#2063)890302a
Support usage as plugin for tools like kubectl (#2018)48cea5c
build(deps): bump actions/checkout from 3 to 4 (#2028)22953d8
Replace all non-alphanumerics in active help env var program prefix (#1940)00b68a1
Add tests for flag completion registration (#2053)b711e87
Don't complete --help flag when flag parsing disabled (#2061)8b1eba4
Fix linter errors (#2052)4cafa37
Allow running persistent run hooks of all parents (#2044)5c962a2
build(deps): bump github.com/cpuguy83/go-md2man/v2 from 2.0.2 to 2.0.3 (#2047)efe8fa3
build(deps): bump actions/setup-go from 3 to 4 (#1934)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)