Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): add specs to hint for pulling unnamed layers #1174

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Nov 6, 2023

What this PR does / why we need it:
This PR adds specs to hint for pulling unnamed layers

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1173

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023

Codecov Report

Merging #1174 (079d8f1) into main (dbf40e4) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #1174      +/-   ##
==========================================
+ Coverage   79.94%   80.02%   +0.08%     
==========================================
  Files          65       65              
  Lines        3560     3560              
==========================================
+ Hits         2846     2849       +3     
+ Misses        497      495       -2     
+ Partials      217      216       -1     

see 1 file with indirect coverage changes

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 1f974f4 into oras-project:main Nov 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need E2E specs on hinting for pulling unnamed layers
4 participants