-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(ci): add workflow for releasing main image #1191
Conversation
this commit adds a github workflow that will build and push a new image whenever a new commit is merged on main branch. Signed-off-by: Anurag <81210977+kranurag7@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1191 +/- ##
==========================================
+ Coverage 80.25% 80.30% +0.05%
==========================================
Files 66 66
Lines 3646 3646
==========================================
+ Hits 2926 2928 +2
+ Misses 505 503 -2
Partials 215 215 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I think what's proposed in this PR can be merged into the https://github.com/oras-project/oras/blob/main/.github/workflows/release-ghcr.yml by changing the prepare job to
TAG=${GITHUB_REF#refs/*/}
echo "ref=ghcr.io/${{ github.repository }}:${TAG}" >> $GITHUB_OUTPUT
This can be done in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Anurag <81210977+kranurag7@users.noreply.github.com> Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
GitHub workflow that will build and push a new image whenever a new commit is merged on main branch.
I added a commit on my fork's main for testing.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1155
Please check the following list: