Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): add workflow for releasing main image #1191

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

kranurag7
Copy link
Contributor

GitHub workflow that will build and push a new image whenever a new commit is merged on main branch.

I added a commit on my fork's main for testing.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1155

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

this commit adds a github workflow that will build and push a new
image whenever a new commit is merged on main branch.

Signed-off-by: Anurag <81210977+kranurag7@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (abe0ce5) 80.25% compared to head (5fc16da) 80.30%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1191      +/-   ##
==========================================
+ Coverage   80.25%   80.30%   +0.05%     
==========================================
  Files          66       66              
  Lines        3646     3646              
==========================================
+ Hits         2926     2928       +2     
+ Misses        505      503       -2     
  Partials      215      215              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qweeah qweeah changed the title Add workflow for releasing main image build(ci): add workflow for releasing main image Nov 24, 2023
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think what's proposed in this PR can be merged into the https://github.com/oras-project/oras/blob/main/.github/workflows/release-ghcr.yml by changing the prepare job to

TAG=${GITHUB_REF#refs/*/}
echo "ref=ghcr.io/${{ github.repository }}:${TAG}" >> $GITHUB_OUTPUT

This can be done in another PR.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 70c8e86 into oras-project:main Dec 19, 2023
6 checks passed
@kranurag7 kranurag7 deleted the kr/main-image branch December 19, 2023 14:55
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
Signed-off-by: Anurag <81210977+kranurag7@users.noreply.github.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a new workflow to build a container image tagged main on PR merge
5 participants