build(ci): make coverage upload and calculation mandatory #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
requested review from
sajayantony,
shizhMSFT,
SteveLasker and
TerryHowe
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1230 +/- ##
==========================================
- Coverage 80.65% 80.59% -0.06%
==========================================
Files 67 67
Lines 3644 3644
==========================================
- Hits 2939 2937 -2
- Misses 493 495 +2
Partials 212 212 ☔ View full report in Codecov by Sentry. |
FeynmanZhou
pushed a commit
to FeynmanZhou/oras
that referenced
this pull request
May 11, 2024
…ct#1230) Signed-off-by: Billy Zha <jinzha1@microsoft.com> Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Sometime codecov job might silently fail without calculating the code coverage and do checking(see logs). This PR enforces the success of codecov job with code check.
Please check the following list: