-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: pass cobra.Command to all cmd exec functions #1285
Conversation
Signed-off-by: Terry Howe <tlhowe@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1285 +/- ##
==========================================
- Coverage 81.92% 81.90% -0.03%
==========================================
Files 83 83
Lines 3995 3996 +1
==========================================
Hits 3273 3273
- Misses 499 500 +1
Partials 223 223 ☔ View full report in Codecov by Sentry. |
@TerryHowe Can you help make the PR title complaint to conventional commits? E.g. for this PR it can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…1285) Signed-off-by: Terry Howe <tlhowe@amazon.com>
What this PR does / why we need it:
This is a minor refactor to make the command private methods consistent. Most of them take a cmd and not a context except for these six. The reason for this is to make logging and output more consistent across the commands and the
corbra.Command
has methods likeOutOrStdout
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: