Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: Multi-arch image management with ORAS #1514

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

FeynmanZhou
Copy link
Member

@FeynmanZhou FeynmanZhou commented Oct 15, 2024

What this PR does / why we need it:

Add a spec: Multi-arch image management with ORAS

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1053

Preview: https://github.com/FeynmanZhou/oras/blob/multi-arch/docs/proposals/multi-arch-image-mgmt.md

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.37%. Comparing base (0abb460) to head (fb6e94d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1514      +/-   ##
==========================================
- Coverage   84.41%   84.37%   -0.04%     
==========================================
  Files         120      120              
  Lines        5460     5460              
==========================================
- Hits         4609     4607       -2     
- Misses        604      606       +2     
  Partials      247      247              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make the spec more professional, please proofread the spec and fix formatting issues.

docs/proposals/img/multi-arch.png Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou FeynmanZhou requested a review from shizhMSFT December 9, 2024 08:58
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but you need to fix the check failure.

docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
Copy link

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for drawing my attention to this, @FeynmanZhou ! 🙏

some very optional comments below, I hope these helps!

docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@TerryHowe
Copy link
Member

@FeynmanZhou
Copy link
Member Author

Maybe add your svgs to https://github.com/oras-project/oras/blob/main/.github/licenserc.yml#L31

Raised a PR to address this issue: #1619

@TerryHowe
Copy link
Member

I updated the branch and tests are passing now.

Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
Copy link

@sudo-bmitch sudo-bmitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment suggesting that various tools do not provide native support for local environment I believe is a reference to the current stable docker engine. There are changes coming with docker, and it's inaccurate with many of the other tools described. https://docs.docker.com/desktop/features/containerd/

docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
docs/proposals/multi-arch-image-mgmt.md Outdated Show resolved Hide resolved
Signed-off-by: feynmanzhou <feynmanzhou@microsoft.com>
Signed-off-by: feynmanzhou <feynmanzhou@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multi-arch image/artifact push
9 participants