Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support certificate authority configuration #380

Merged
merged 8 commits into from
May 16, 2022
Merged

Support certificate authority configuration #380

merged 8 commits into from
May 16, 2022

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented May 11, 2022 •
edited
Loading

This PR enables configuring certificate authority files for registry client.

For now this was only used in login command but will also be applied to pull and push commands after revamping.

#217

@qweeah
Support certificate authority configuration
92102d0 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Change option type and rename
e0b5837 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Change flag description
bb1f872 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Update flag description
231a91f 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Code clean
b07fd1d 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Code clean
db63fe9 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@shizhMSFT shizhMSFT modified the milestones: v0.14.0, v0.13.0 May 16, 2022
shizhMSFT
shizhMSFT reviewed May 16, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR needs to revisited and merged after migrating to oras-go v2 for oras pull and push as root CA options not only apply to login but also to pull and push.

cmd/oras/login.go Outdated Show resolved Hide resolved
cmd/oras/login.go Outdated Show resolved Hide resolved
cmd/oras/login.go Outdated Show resolved Hide resolved
internal/http/certificate.go Outdated Show resolved Hide resolved
internal/http/certificate.go Outdated Show resolved Hide resolved
internal/http/certificate.go Outdated Show resolved Hide resolved
internal/http/client_test.go Outdated Show resolved Hide resolved
@qweeah qweeah mentioned this pull request May 16, 2022
Closed
@qweeah
Resolve comments
6775163 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Code clean
033f241 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah requested a review from shizhMSFT May 16, 2022 10:28
shizhMSFT
shizhMSFT approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for login. Still pending PRs for pull and push.

@shizhMSFT shizhMSFT merged commit 5f6a1e7 into oras-project:main May 16, 2022
@qweeah qweeah deleted the ca-file branch August 25, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@qweeah @shizhMSFT