feat!: force deleting a non-existent blob/manifest #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #745 +/- ##
=======================================
Coverage 73.46% 73.46%
=======================================
Files 17 17
Lines 588 588
=======================================
Hits 432 432
Misses 125 125
Partials 31 31 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
approved these changes
Jan 12, 2023
| } | ||
|
|
||
| // ApplyFlags applies flags to a command flag set. | ||
| func (opts *Confirmation) ApplyFlags(fs *pflag.FlagSet) { | ||
| fs.BoolVarP(&opts.Confirmed, "force", "f", false, "do not prompt for confirmation") | ||
| fs.BoolVarP(&opts.Force, "force", "f", false, "do not prompt for confirmation") |
There was a problem hiding this comment.
nit: Should we consider ignore non-existent references, never prompt over do not prompt for confirmation? /cc @FeynmanZhou
There was a problem hiding this comment.
Looks good. Also nonexistent is a word and is already used by rm manual.
There was a problem hiding this comment.
Agree with @shizhMSFT 's suggestion. I see @qweeah has incorporated it into the confirmation.
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
added a commit
to qweeah/oras
that referenced
this pull request
Jan 13, 2023
Resolves oras-project#722 Signed-off-by: Billy Zha <jinzha1@microsoft.com>
TerryHowe
pushed a commit
to TerryHowe/oras
that referenced
this pull request
Feb 2, 2023
Resolves oras-project#722 Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #722
Signed-off-by: Billy Zha jinzha1@microsoft.com