feat(oci-layout): support in fetch and push for manifest and blob commands #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Wwwsylvia
reviewed
Jan 17, 2023
shizhMSFT
reviewed
Jan 17, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
FeynmanZhou
reviewed
Jan 18, 2023
| oras blob fetch --output blob.tar.gz --descriptor localhost:5000/hello@sha256:9a201d228ebd966211f7d1131be19f152be428bd373a92071c71d8deaf83b3e5 | ||
|
|
||
| Example - Fetch and print a blob from OCI image layout folder 'layout-dir': |
There was a problem hiding this comment.
Is it exact to use layout-dir@sha256:9a201d228ebd966211f7d1131be19f152be428bd373a92071c71d8deaf83b3e5 to represent an OCI layout folder?
There was a problem hiding this comment.
layout-dir@sha256:9a201d228ebd966211f7d1131be19f152be428bd373a92071c71d8deaf83b3e5 means fetch a blob with digest sha256:9a201d228ebd966211f7d1131be19f152be428bd373a92071c71d8deaf83b3e5 from an OCI image layout folder 'layout-dir'
FeynmanZhou
reviewed
Jan 18, 2023
cmd/oras/manifest/push.go
Outdated
| @@ -75,19 +74,22 @@ Example - Push a manifest to repository 'locahost:5000/hello' and tag with 'tag1 | |||
|
|
|||
| Example - Push a manifest to repository 'locahost:5000/hello' and tag with 'tag1', 'tag2', 'tag3' and concurrency level tuned: | |||
| oras manifest push --concurrency 6 localhost:5000/hello:tag1,tag2,tag3 manifest.json | |||
|
|
|||
| Example - Push a manifest to an OCI layout folder 'layout-dir' and with tag 'latest': | |||
There was a problem hiding this comment.
Should we use tag with 'latest' to keep consistent with other examples?
There was a problem hiding this comment.
I will update all tags to 'latest' to make it consistent.
There was a problem hiding this comment.
Sorry I guess I misunderstand your intent, will rephrase to tag with
FeynmanZhou
reviewed
Jan 18, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
TerryHowe
pushed a commit
to TerryHowe/oras
that referenced
this pull request
Feb 2, 2023
…mands (oras-project#752) Related to oras-project#378 Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #378