feat: support artifact discovering in OCI image layout #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #765 +/- ##
==========================================
- Coverage 63.86% 61.54% -2.32%
==========================================
Files 19 20 +1
Lines 714 801 +87
==========================================
+ Hits 456 493 +37
- Misses 225 268 +43
- Partials 33 40 +7 ☔ View full report in Codecov by Sentry. |
qweeah
changed the title
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
This reverts commit bf77ecc. Signed-off-by: Billy Zha <jinzha1@microsoft.com>
This reverts commit f0fc6b8. Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
cmd/oras/discover.go
Outdated
| var fetched []byte | ||
| if rc, err := target.Fetch(ctx, node); err != nil { | ||
| return nil, err | ||
| } else { |
There was a problem hiding this comment.
The else enclosing can be deleted.
There was a problem hiding this comment.
If else is deleted, then rc will be undefined.
There was a problem hiding this comment.
It reminds me that I can actually use https://pkg.go.dev/oras.land/oras-go/v2#FetchBytes to avoid reading from rc myself
There was a problem hiding this comment.
rc is not deferred to be closed.
shizhMSFT
reviewed
Jan 29, 2023
cmd/oras/discover.go
Outdated
| }) | ||
| if err != nil { | ||
| return nil, err | ||
| func fetchReferrers(ctx context.Context, target oras.ReadOnlyGraphTarget, desc ocispec.Descriptor, artifactType string) ([]ocispec.Descriptor, error) { |
There was a problem hiding this comment.
Can we put this function into a package so that we can have unit tests?
shizhMSFT
reviewed
Jan 29, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
reviewed
Jan 29, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds OCI image layout support for
oras discovercommand and resolves #760. The UX is consistent with remote registry and looks like below:Signed-off-by: Billy Zha jinzha1@microsoft.com