-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add feature marks to cmd description and log #865
Conversation
@qweeah Are there any flags for |
No, there is no flag. But when used, there will be a log output saying it's an experimental feature in verbose mode. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #865 +/- ##
=======================================
Coverage 66.39% 66.39%
=======================================
Files 21 21
Lines 860 860
=======================================
Hits 571 571
Misses 243 243
Partials 46 46
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM but IANAM |
@qweeah What's the reason for making the following three commands to Preview status in v1.0.0?
|
Basically, because the underlying specs are not released. Commented inline. |
Make sense. Agree with the changes above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
What this PR does / why we need it:
This PR updates feature marks to commands and features as summarized below:
oras blob
oras blob fetch
oras blob delete
oras blob push
oras manifest
oras manifest fetch
oras manifest fetch-config
oras manifest delete
oras manifest push
oras repo
oras repo ls
oras repo tags
oras cp
oras attach
,oras discover
: since the command always involves referrer API change, GA requires distribution-spec v1.1 releaseexperimental commands
none
preview features
--distribution-spec
: oci distribution spec v1.1 is not releasedoras pull --include-subject
: image with subject will be defined in oci image-spec v1.1oras cp --recursive
: recursively upward lookup for referrers requires referrer API in oci distribution spec v1.1oras repo tags --exclude-digest-tags
: it uses the tag scheme as fallback referrers API fallback and defined in oci distribution spec v1.1--image-spec
: uses artifact manifestoras repo tags
: should print experimental hint when using associated tag/digest queryingWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #860
Please check the following list: