Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: using cross compilation in docker build #938

Merged
merged 1 commit into from
Apr 28, 2023
Merged

build: using cross compilation in docker build #938

merged 1 commit into from
Apr 28, 2023

Conversation

northtyphoon
Copy link
Contributor

What this PR does / why we need it:

The change follows https://docs.docker.com/build/guide/multi-platform/#build-using-cross-compilation to switch oras docker release build to cross-compilation. It boosts the build performance by ~7x.

Existing using emulation: 12m 9s.
New using cross-compilation : 1m 39s

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test? Yes
  • Does this change require a documentation update? No
  • Does this introduce breaking changes that would require an announcement or bumping the major version? No
  • Do all new files have an appropriate license header? N/A

@northtyphoon
build: using cross compilation in docker build
e1c211e 
Signed-off-by: Bin Du <bindu@microsoft.com>
shizhMSFT
shizhMSFT approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 776041f into oras-project:main Apr 28, 2023
This was referenced Jul 5, 2023
Closed
Merged
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
@northtyphoon @shizhMSFT
build: using cross compilation in docker build (oras-project#938)
2aeaa35 
Signed-off-by: Bin Du <bindu@microsoft.com>
@ZhongRuoyu ZhongRuoyu mentioned this pull request Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

@qweeah qweeah Awaiting requested review from qweeah qweeah is a code owner

@TerryHowe TerryHowe Awaiting requested review from TerryHowe TerryHowe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@northtyphoon @shizhMSFT