-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use golangci lint #986
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #986 +/- ##
=======================================
Coverage 81.26% 81.26%
=======================================
Files 53 53
Lines 2776 2776
=======================================
Hits 2256 2256
Misses 352 352
Partials 168 168 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested to align with other actions.
Also this PR requires fixing of all detected issues otherwise the PR check will fail. @kranurag7 Do you want to do the fixing? If not have time I can add another PR to fix all the lint issues found.
@kranurag7 Can you add signoff as is suggested in https://github.com/oras-project/oras/pull/986/checks?check_run_id=14956872091:
|
I just rebased, so you are going to have to |
Signed-off-by: Anurag <contact.anurag7@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Anurag <contact.anurag7@gmail.com> Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Anurag <contact.anurag7@gmail.com> Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Anurag <contact.anurag7@gmail.com>
What this PR does / why we need it:
The following are the places that's giving some errors as of now according to the linter.
output of running golangci locally
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #981
Please check the following list: