Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): add test for pushing via absolute path #991

Merged
merged 31 commits into from
Jun 29, 2023
Merged

test(e2e): add test for pushing via absolute path #991

merged 31 commits into from
Jun 29, 2023

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Jun 27, 2023 •
edited
Loading

What this PR does / why we need it:
This PR adds E2E tests that validate the absolute path checking for oras push and oras attach. Depends on merging of #988

suganyas and others added 25 commits June 27, 2023 20:28
@suganyas
Add changes for fixing the absolute path behaviour in oras push and a…
1ebb328 
…ttach

Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @qweeah
Update cmd/oras/internal/option/packer.go
a68ed83 
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @qweeah
Update cmd/oras/internal/option/packer.go
3337a5e 
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @qweeah
Update cmd/oras/root/pull.go
f62a8b4 
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas
Address review comments from Billy and tested code
10901c0 
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @qweeah
Update cmd/oras/internal/option/packer.go
08c4593 
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @qweeah
Update cmd/oras/internal/option/packer.go
4392939 
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @qweeah
Update cmd/oras/internal/option/packer.go
a8d7abf 
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @qweeah
Update cmd/oras/root/pull.go
74ef557 
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @qweeah
Update cmd/oras/internal/option/packer.go
e417954 
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @qweeah
Update cmd/oras/internal/option/packer.go
ea6600c 
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas
Fix the build for compilation error
e0d769f 
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@qweeah
test(e2e): add test for pushing via absolute path
a548ad4 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@suganyas @qweeah
Add changes for fixing the absolute path behaviour in oras push and a…
755a83c 
…ttach

Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @qweeah
Update cmd/oras/internal/option/packer.go
caec5ff 
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @qweeah
Update cmd/oras/internal/option/packer.go
007b2d9 
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @qweeah
Update cmd/oras/root/pull.go
8f447bd 
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @qweeah
Address review comments from Billy and tested code
de4bdb7 
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @qweeah
Update cmd/oras/internal/option/packer.go
351a110 
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @qweeah
Update cmd/oras/internal/option/packer.go
e03dec7 
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @qweeah
Update cmd/oras/internal/option/packer.go
8f03f50 
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @qweeah
Update cmd/oras/root/pull.go
af7c0ea 
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @qweeah
Update cmd/oras/internal/option/packer.go
2609e2f 
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @qweeah
Update cmd/oras/internal/option/packer.go
d1dd526 
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @qweeah
Fix the build for compilation error
0c656ee 
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@shizhMSFT shizhMSFT added this to the v1.1.0 milestone Jun 28, 2023
suganyas and others added 4 commits June 28, 2023 19:50
@suganyas @shizhMSFT
Update cmd/oras/internal/option/packer.go
8420368 
Co-authored-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @shizhMSFT
Update cmd/oras/root/pull.go
f3549cd 
Co-authored-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@suganyas @shizhMSFT
Update cmd/oras/internal/option/packer.go
ae964ec 
Co-authored-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: suganyas <ssuganyatce@gmail.com>
@qweeah
Merge remote-tracking branch 'suganyas/main' into e2e-path
0c37583
@codecov-commenter
Copy link

Codecov Report

Merging #991 (0c37583) into main (bf33bb7) will decrease coverage by 0.18%.
The diff coverage is 68.42%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #991      +/-   ##
==========================================
- Coverage   81.26%   81.08%   -0.18%     
==========================================
  Files          53       53              
  Lines        2776     2792      +16     
==========================================
+ Hits         2256     2264       +8     
- Misses        352      358       +6     
- Partials      168      170       +2
Impacted Files Coverage Δ
cmd/oras/root/attach.go 82.50% <ø> (-0.15%) ⬇️
cmd/oras/root/pull.go 73.62% <0.00%> (-1.38%) ⬇️
cmd/oras/root/push.go 73.83% <ø> (-0.16%) ⬇️
cmd/oras/internal/option/packer.go 90.62% <81.25%> (-3.13%) ⬇️

... and 1 file with indirect coverage changes

@qweeah qweeah marked this pull request as ready for review June 28, 2023 10:58
shizhMSFT
shizhMSFT approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 5e2cfe9 into oras-project:main Jun 29, 2023
This was referenced Jul 5, 2023
Closed
Merged
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
@qweeah @shizhMSFT
test(e2e): add test for pushing via absolute path (oras-project#991)
a143004 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@ZhongRuoyu ZhongRuoyu mentioned this pull request Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

@TerryHowe TerryHowe Awaiting requested review from TerryHowe TerryHowe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
ORAS Project Board-2023
Status: Done
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@qweeah @codecov-commenter @shizhMSFT @suganyas