Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 Upgrade #9

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

skunde
Copy link
Contributor

@skunde skunde commented Jun 9, 2021

Hi @orasik

would you consider a new release based on this pull request?

  • enable support for PHP 8, raised the PHP requirements to the latest supported versions (7.3 - 8.0)
  • replaced deprecated zendframework/zend-stratigility with successor laminas/laminas-stratigility
  • upgraded all dependencies to the latest versions
  • fixed one test case because the new phpunit 9 was complaining

Things that might need improvement:

  • phpunit 9 complains about two test cases without any assert's being called
  • documentation: I just replaced mentions of Zend Expressive with its successor mezzio
  • travis.yml: I have no way of testing my changes at the moment
  • I think you could drop the reference to laminas/laminas-stratigility in composer.json because I found no reference of the former zendframework namespace in your code.

Cheers, Stefan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant