Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a global_handlers role to collect handlers needed by different roles #454

Closed
ThiloSolbrig opened this issue Apr 26, 2024 · 1 comment · Fixed by #455
Closed

Introduce a global_handlers role to collect handlers needed by different roles #454

ThiloSolbrig opened this issue Apr 26, 2024 · 1 comment · Fixed by #455
Labels
enhancement
Milestone
4.9

Comments

@ThiloSolbrig
Copy link
Contributor

  • Certain handlers might be useful for more than one role (e.g., restarting the server after package updates or kernel parameter changes). Instead of defining them redundantly in each role, a new role is introduced to collect those roles. Any role which needs those handlers, e.g. can import them via a role dependency.
  • As a first shot
    • "restart server" handler will be moved there.
    • "restart if needed" handler will be introduced, which checks the system for reboot recommendation, e.g. after package updates
    • "restart server" handler will be changed from forced reboot to configurable reboot (actually reboot or just display reboot advisory only). This is because it might be inacceptable to accidently reboot a production system, for instance.
@Rendanic Rendanic added this to the 4.9 milestone Apr 26, 2024
@ThiloSolbrig
Copy link
Contributor Author

Implemented by: #455

@ThiloSolbrig ThiloSolbrig mentioned this issue Apr 26, 2024
Closed
ThiloSolbrig pushed a commit to ThiloSolbrig/ansible-oracle that referenced this issue Apr 26, 2024
Merge branch 'enhancement#oravirt#454-global-handlers' into condition…
03d8604 
…al-reboot
@Rendanic Rendanic linked a pull request Apr 26, 2024 that will close this issue
Introduce a global handlers role #455
Merged
ThiloSolbrig pushed a commit to ThiloSolbrig/ansible-oracle that referenced this issue Apr 26, 2024
Merge branch 'enhancement#oravirt#454-global-handlers' into disable-t…
5a34a9c 
…ransparent-hugepages
ThiloSolbrig pushed a commit to ThiloSolbrig/ansible-oracle that referenced this issue May 14, 2024
consolidate changes into dev
24255c5 
* enhancement#oravirt#454-global-handlers
* enhancement#444-asm-failgroup-support
* enhancement#446-configure-etc-hosts
* enhancement#448-optional-logrotate
* enhancement#450-sysctl-from-database-sizing
* enhancement#452-oracle_script_env
* enhancement#456-conditional-reboot
* enhancement#459-disable-transparent-hugepages
* issue#430-cvuqdisk-on-fips
ThiloSolbrig pushed a commit to ThiloSolbrig/ansible-oracle that referenced this issue May 15, 2024
consolidate changes into dev
df01433 
* enhancement#oravirt#454-global-handlers
* enhancement#444-asm-failgroup-support
* enhancement#446-configure-etc-hosts
* enhancement#448-optional-logrotate
* enhancement#450-sysctl-from-database-sizing
* enhancement#452-oracle_script_env
* enhancement#456-conditional-reboot
* enhancement#459-disable-transparent-hugepages
* issue#430-cvuqdisk-on-fips
* ssh_user_equivalence
ThiloSolbrig pushed a commit to ThiloSolbrig/ansible-oracle that referenced this issue May 16, 2024
consolidate changes into dev
d8dab76 
* enhancement#oravirt#454-global-handlers
* enhancement#444-asm-failgroup-support
* enhancement#446-configure-etc-hosts
* enhancement#448-optional-logrotate
* enhancement#450-sysctl-from-database-sizing
* enhancement#452-oracle_script_env
* enhancement#456-conditional-reboot
* enhancement#459-disable-transparent-hugepages
* issue#430-cvuqdisk-on-fips
* ssh_user_equivalence
ThiloSolbrig pushed a commit to ThiloSolbrig/ansible-oracle that referenced this issue May 17, 2024
consolidate changes into dev
876c6e3 
* enhancement#oravirt#454-global-handlers
* enhancement#444-asm-failgroup-support
* enhancement#446-configure-etc-hosts
* enhancement#448-optional-logrotate
* enhancement#450-sysctl-from-database-sizing
* enhancement#452-oracle_script_env
* enhancement#456-conditional-reboot
* enhancement#459-disable-transparent-hugepages
* issue#430-cvuqdisk-on-fips
* ssh_user_equivalence
* absolute-filesources
ThiloSolbrig pushed a commit to ThiloSolbrig/ansible-oracle that referenced this issue May 22, 2024
consolidate changes into dev
4587048 
* enhancement#oravirt#454-global-handlers
* enhancement#444-asm-failgroup-support
* enhancement#446-configure-etc-hosts
* enhancement#448-optional-logrotate
* enhancement#450-sysctl-from-database-sizing
* enhancement#452-oracle_script_env
* enhancement#456-conditional-reboot
* enhancement#459-disable-transparent-hugepages
* issue#430-cvuqdisk-on-fips
* ssh_user_equivalence
* absolute-filesources
* empty-device_persistence
ThiloSolbrig pushed a commit to ThiloSolbrig/ansible-oracle that referenced this issue May 22, 2024
consolidate changes into dev
4d1c6f5 
* enhancement#oravirt#454-global-handlers
* enhancement#444-asm-failgroup-support
* enhancement#446-configure-etc-hosts
* enhancement#448-optional-logrotate
* enhancement#450-sysctl-from-database-sizing
* enhancement#452-oracle_script_env
* enhancement#456-conditional-reboot
* enhancement#459-disable-transparent-hugepages
* issue#430-cvuqdisk-on-fips
* ssh_user_equivalence
* absolute-filesources
* empty-device_persistence
* opatch-check-on-2nd
* creates-readme
ThiloSolbrig pushed a commit to ThiloSolbrig/ansible-oracle that referenced this issue May 23, 2024
consolidate changes into dev
748b69f 
* enhancement#oravirt#454-global-handlers
* enhancement#444-asm-failgroup-support
* enhancement#446-configure-etc-hosts
* enhancement#448-optional-logrotate
* enhancement#450-sysctl-from-database-sizing
* enhancement#452-oracle_script_env
* enhancement#456-conditional-reboot
* enhancement#459-disable-transparent-hugepages
* issue#430-cvuqdisk-on-fips
* ssh_user_equivalence
* absolute-filesources
* empty-device_persistence
* opatch-check-on-2nd
* creates-readme
* oracle_opatch-env-support
* etc-hosts-jinja-fix
ThiloSolbrig pushed a commit to ThiloSolbrig/ansible-oracle that referenced this issue Sep 18, 2024
consolidate changes into dev
07fd904 
* enhancement#oravirt#454-global-handlers
* enhancement#444-asm-failgroup-support
* enhancement#446-configure-etc-hosts
* enhancement#448-optional-logrotate
* enhancement#450-sysctl-from-database-sizing
* enhancement#452-oracle_script_env
* enhancement#456-conditional-reboot
* enhancement#459-disable-transparent-hugepages
* issue#430-cvuqdisk-on-fips
* ssh_user_equivalence
* absolute-filesources
* empty-device_persistence
* opatch-check-on-2nd
* creates-readme
* oracle_opatch-env-support
* etc-hosts-jinja-fix
ThiloSolbrig pushed a commit to ThiloSolbrig/ansible-oracle that referenced this issue Sep 19, 2024
consolidate changes into dev
d2480e8 
* enhancement#oravirt#454-global-handlers
* enhancement#444-asm-failgroup-support
* enhancement#446-configure-etc-hosts
* enhancement#448-optional-logrotate
* enhancement#450-sysctl-from-database-sizing
* enhancement#452-oracle_script_env
* enhancement#456-conditional-reboot
* enhancement#459-disable-transparent-hugepages
* issue#430-cvuqdisk-on-fips
* ssh_user_equivalence
* absolute-filesources
* empty-device_persistence
* opatch-check-on-2nd
* creates-readme
* oracle_opatch-env-support
* etc-hosts-jinja-fix
ThiloSolbrig pushed a commit to ThiloSolbrig/ansible-oracle that referenced this issue Sep 19, 2024
consolidate changes into dev
3f27e42 
* enhancement#oravirt#454-global-handlers
* enhancement#444-asm-failgroup-support
* enhancement#446-configure-etc-hosts
* enhancement#448-optional-logrotate
* enhancement#450-sysctl-from-database-sizing
* enhancement#452-oracle_script_env
* enhancement#456-conditional-reboot
* enhancement#459-disable-transparent-hugepages
* issue#430-cvuqdisk-on-fips
* ssh_user_equivalence
* absolute-filesources
* empty-device_persistence
* opatch-check-on-2nd
* creates-readme
* oracle_opatch-env-support
* etc-hosts-jinja-fix
ThiloSolbrig pushed a commit to ThiloSolbrig/ansible-oracle that referenced this issue Sep 19, 2024
consolidate changes into dev
a88aa27 
* enhancement#oravirt#454-global-handlers
* enhancement#444-asm-failgroup-support
* enhancement#446-configure-etc-hosts
* enhancement#448-optional-logrotate
* enhancement#450-sysctl-from-database-sizing
* enhancement#452-oracle_script_env
* enhancement#456-conditional-reboot
* enhancement#459-disable-transparent-hugepages
* issue#430-cvuqdisk-on-fips
* ssh_user_equivalence
* absolute-filesources
* empty-device_persistence
* opatch-check-on-2nd
* creates-readme
* oracle_opatch-env-support
* etc-hosts-jinja-fix
* use-host_fs_layout-4-non-fs-devices
* skip-runcluvfy-when-gi_ignoreprereq
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.9
Development

Successfully merging a pull request may close this issue.

Introduce a global handlers role ThiloSolbrig/ansible-oracle
2 participants
@Rendanic @ThiloSolbrig