Use same input if for policy if they have same tap and config #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Jan 21, 2022
ghost
commented
- Only create Input Stream if the config and tap is different
- generate hash from Configurable data
- Add vector of policies that are using the input in InputStream
- InputStream name : tap + "-" + hash of input config
ghost
force-pushed
the
feature/efficient-use-taps
branch
from
7dc62d9
to
142f426
Compare
weyrick
requested changes
Jan 21, 2022
ghost
commented
Jan 24, 2022
ghost
linked an issue
ghost
commented
Jan 24, 2022
weyrick
requested changes
Jan 24, 2022
weyrick
approved these changes
Jan 24, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.