Feature/metrics groups #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Feb 9, 2022
ghost
commented
Feb 9, 2022
weyrick
requested changes
Feb 9, 2022
ghost
force-pushed
the
feature/metrics-groups
branch
from
f83fdeb
to
b354c61
Compare
ghost
commented
Feb 10, 2022
ghost
commented
Feb 10, 2022
ghost
force-pushed
the
feature/metrics-groups
branch
2 times, most recently
from
a6b8b83
to
56a00c8
Compare
ghost
linked an issue
Closed
added 4 commits
February 16, 2022 11:45
ghost
force-pushed
the
feature/metrics-groups
branch
from
bb3a7cc
to
987c72a
Compare
ghost
commented
Feb 18, 2022
weyrick
requested changes
Feb 21, 2022
src/StreamHandler.h
Outdated
|
|
||
| if (config_exists("enable")) { | ||
| for (const auto &group : config_get<StringList>("enable")) { | ||
| _groups.set(group_defs.at(group)); |
There was a problem hiding this comment.
so I think we want the extra error handling here to include the available group names (keys from group_defs)
added 3 commits
February 21, 2022 15:20
ghost
commented
Feb 21, 2022
weyrick
requested changes
Feb 22, 2022
| _dns_topNX.to_json(j); | ||
| _dns_topREFUSED.to_json(j); | ||
| _dns_topSRVFAIL.to_json(j); | ||
| _dns_topRCode.to_json(j, [](const uint16_t &val) { |
| _dns_topNX.to_prometheus(out, add_labels); | ||
| _dns_topREFUSED.to_prometheus(out, add_labels); | ||
| _dns_topSRVFAIL.to_prometheus(out, add_labels); | ||
| _dns_topRCode.to_prometheus(out, add_labels, [](const uint16_t &val) { |
weyrick
approved these changes
Feb 22, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.