Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify pktvisor CMake to allow it to be added as subdirectory in othe… #236

Merged
2 commits merged into from
Mar 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ if(VISOR_PRERELEASE STREQUAL "-develop" OR VISOR_PRERELEASE STREQUAL "-rc")
execute_process(
COMMAND
git rev-parse --short HEAD
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}
RESULT_VARIABLE
SHORT_HASH_RESULT
OUTPUT_VARIABLE
Expand All @@ -41,13 +41,13 @@ set(VISOR_VERSION "pktvisor ${PROJECT_VERSION}${VISOR_PRERELEASE}")
# used in CI
file(WRITE ${CMAKE_BINARY_DIR}/VERSION ${VISOR_VERSION_NUM})
# golang version
configure_file(golang/pkg/client/version.go.in ${CMAKE_SOURCE_DIR}/golang/pkg/client/version.go)
configure_file(golang/pkg/client/version.go.in ${PROJECT_SOURCE_DIR}/golang/pkg/client/version.go)

####### end version code #######

if(NOT DEFINED ENV{VERSION_ONLY})

list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake")
list(APPEND CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/cmake")

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
Expand Down Expand Up @@ -77,7 +77,7 @@ if(PKTVISOR_CONAN_INIT)
endif()

conan_cmake_install(
PATH_OR_REFERENCE ${CMAKE_SOURCE_DIR}
PATH_OR_REFERENCE ${PROJECT_SOURCE_DIR}
BUILD ${PKTVISOR_CONAN_BUILD}
PROFILE_BUILD ${PKTVISOR_CONAN_BUILD_PROFILE}
PROFILE_HOST ${PKTVISOR_CONAN_HOST_PROFILE}
Expand Down
5 changes: 0 additions & 5 deletions cmd/pktvisor-pcap/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
add_executable(pktvisor-pcap main.cpp)

target_include_directories(pktvisor-pcap
PRIVATE
${CMAKE_BINARY_DIR}/src # Visor::Core config.h
)

target_link_libraries(pktvisor-pcap
PRIVATE
${CONAN_LIBS_DOCOPT.CPP}
Expand Down
5 changes: 0 additions & 5 deletions cmd/pktvisor-reader/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
add_executable(pktvisor-reader main.cpp)

target_include_directories(pktvisor-reader
PRIVATE
${CMAKE_BINARY_DIR}/src # Visor::Core config.h
)

target_link_libraries(pktvisor-reader
PRIVATE
${CONAN_LIBS_DOCOPT.CPP}
Expand Down
5 changes: 0 additions & 5 deletions cmd/pktvisord/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
add_executable(pktvisord main.cpp)

target_include_directories(pktvisord
PRIVATE
${CMAKE_BINARY_DIR}/src # Visor::Core config.h
)

target_link_libraries(pktvisord
PRIVATE
timer
Expand Down
6 changes: 3 additions & 3 deletions src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ add_library(visor-core
add_library(Visor::Core ALIAS visor-core)

target_include_directories(visor-core
PRIVATE
${CMAKE_BINARY_DIR}/src # Visor::Core config.h
PUBLIC
${CMAKE_CURRENT_BINARY_DIR} # Visor::Core config.h
INTERFACE
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
)
Expand Down Expand Up @@ -63,6 +63,6 @@ target_include_directories(unit-tests-vizor-core
target_link_libraries(unit-tests-vizor-core PRIVATE Visor::Core ${VISOR_STATIC_PLUGINS})

add_test(NAME unit-tests-vizor-core
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}/src
WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}/src
COMMAND unit-tests-vizor-core
)
2 changes: 1 addition & 1 deletion src/handlers/dhcp/tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ target_link_libraries(unit-tests-handler-dhcp
Visor::Handler::Dhcp)

add_test(NAME unit-tests-handler-dhcp
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}/src
WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}/src
COMMAND unit-tests-handler-dhcp
)
2 changes: 1 addition & 1 deletion src/handlers/dns/tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ target_link_libraries(unit-tests-handler-dns
Visor::Handler::Dns)

add_test(NAME unit-tests-handler-dns
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}/src
WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}/src
COMMAND unit-tests-handler-dns
)

Expand Down
2 changes: 1 addition & 1 deletion src/handlers/net/tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ target_link_libraries(unit-tests-handler-net
Visor::Handler::Net)

add_test(NAME unit-tests-handler-net
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}/src
WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}/src
COMMAND unit-tests-handler-net
)
2 changes: 1 addition & 1 deletion src/handlers/pcap/tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ target_link_libraries(unit-tests-handler-pcap
Visor::Handler::Pcap)

add_test(NAME unit-tests-handler-pcap
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}/src
WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}/src
COMMAND unit-tests-handler-pcap
)
2 changes: 1 addition & 1 deletion src/inputs/dnstap/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,6 @@ target_link_libraries(unit-tests-input-dnstap
)

add_test(NAME unit-tests-input-dnstap
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}/src
WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}/src
COMMAND unit-tests-input-dnstap
)
2 changes: 1 addition & 1 deletion src/inputs/mock/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ target_link_libraries(unit-tests-input-mock
)

add_test(NAME unit-tests-input-mock
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}/src
WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}/src
COMMAND unit-tests-input-mock
)
2 changes: 1 addition & 1 deletion src/inputs/pcap/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@ target_link_libraries(unit-tests-input-pcap
)

add_test(NAME unit-tests-input-pcap
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}/src
WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}/src
COMMAND unit-tests-input-pcap
)
2 changes: 1 addition & 1 deletion src/inputs/sflow/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,6 @@ target_link_libraries(unit-tests-input-sflow
)

add_test(NAME unit-tests-input-sflow
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}/src
WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}/src
COMMAND unit-tests-input-sflow
)