Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/configurable topn count #308

Merged
merged 5 commits into from
Jun 29, 2022
Merged

Conversation

leoparente
Copy link
Collaborator

No description provided.

@leoparente leoparente self-assigned this Jun 23, 2022
@leoparente leoparente linked an issue Jun 23, 2022 that may be closed by this pull request
@leoparente
Copy link
Collaborator Author

@rboucher-ns1 i did it per policy at same level of deep sample and periods should it be at each handler level?
@weyrick what are your thoughts?

@rboucher-me
Copy link

The ideal scenario would be to set it at the individual metric level in the handler configuration (dns_top_qnames3_items=20). Second-best would be at the handler level (top_items=20).
That said, I think setting this at the policy level is sufficient. The purpose of this is to allow us to do some testing and tuning (particularly for flow metrics) to find the ideal compromise between data granularity and compute/storage requirements.

src/Metrics.h Outdated Show resolved Hide resolved
RFCs/2021-04-16-76-collection-policies.md Outdated Show resolved Hide resolved
src/AbstractMetricsManager.h Outdated Show resolved Hide resolved
@leoparente leoparente requested a review from weyrick June 24, 2022 17:59
src/AbstractMetricsManager.h Outdated Show resolved Hide resolved
src/Metrics.h Outdated Show resolved Hide resolved
src/Metrics.h Outdated Show resolved Hide resolved
@leoparente leoparente requested a review from weyrick June 28, 2022 22:33
@leoparente leoparente merged commit 988e68a into develop Jun 29, 2022
@leoparente leoparente deleted the feature/configurable-topn-count branch June 29, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top 10 metrics: Make "10" a configurable parameter
3 participants