Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement chaining flow for TCP packets #609

Merged
merged 8 commits into from
Jan 18, 2023
Merged

Implement chaining flow for TCP packets #609

merged 8 commits into from
Jan 18, 2023

Conversation

leoparente
Copy link
Collaborator

No description provided.

@leoparente leoparente added the enhancement New feature or request label Jan 13, 2023
@leoparente leoparente self-assigned this Jan 13, 2023
@leoparente leoparente marked this pull request as ready for review January 16, 2023 14:39
weyrick
weyrick approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@weyrick weyrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you summarize the strategy implemented here in the PR description before landing please?

src/handlers/net/NetStreamHandler.cpp Show resolved Hide resolved
@leoparente
Copy link
Collaborator Author

Can you summarize the strategy implemented here in the PR description before landing please?

@weyrick I will do a explanation thread here

Firstly, let start with Pktvisor PCAP flow:

Team document

@leoparente
Copy link
Collaborator Author

Here is the sample and explanation. after doing the explanation... I thought more about the implementation and I think we should rename the new tcp_signal to tcp_reassembled_signal

Team document (1)

@leoparente leoparente merged commit 602d7b1 into develop Jan 18, 2023
@leoparente leoparente deleted the spike/pkt-67-chaining-tcp-data branch January 18, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weyrick weyrick weyrick approved these changes

@rboucher-me rboucher-me Awaiting requested review from rboucher-me

Assignees

@leoparente leoparente

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leoparente @weyrick