Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate some modules to Scala 3 #6491

Open
ebruchez opened this issue Sep 13, 2024 · 2 comments
Open

Migrate some modules to Scala 3 #6491

ebruchez opened this issue Sep 13, 2024 · 2 comments
Assignees
@ebruchez
Labels
Area: Build

Comments

@ebruchez
Copy link
Collaborator

Now that we are on Scala 2.13 (#4086), we can consider some migrations to Scala 3. We should be able to migrate some modules one by one.

The only drawback I can think of is that IntelliJ support might not be up to par yet.
@ebruchez ebruchez self-assigned this Sep 13, 2024
ebruchez pushed a commit that referenced this issue Sep 17, 2024
For #4086/#6491: remove 2.12 dependencies, prep for Scala 3
3f96718
ebruchez pushed a commit that referenced this issue Sep 17, 2024
For #4086/#6491: upgrade scala-async and fix JS inclusion
ccd9be7
ebruchez pushed a commit that referenced this issue Sep 17, 2024
For #4086/#6491: address some warnings/future errors
e045ac0
ebruchez pushed a commit that referenced this issue Sep 17, 2024
For #4086/#6491: enable Scala 3 features with 2.13
3f1d8f1
ebruchez pushed a commit that referenced this issue Sep 17, 2024
For #4086/#6491: use Scala 3 import wildcards
7a48a7c
ebruchez pushed a commit that referenced this issue Sep 17, 2024
For #4086/#6491: -Xsource-features:v2.13.14
507b666
ebruchez pushed a commit that referenced this issue Sep 17, 2024
For #4086/#6491: syntax upgrades
0e88a2c
ebruchez pushed a commit that referenced this issue Sep 17, 2024
For #4086/#6491: fix test with -Xsource-features:v2.13.14
e5fb547
ebruchez pushed a commit that referenced this issue Sep 17, 2024
For #4086/#6491: fixes for CE
18d3ceb
ebruchez pushed a commit that referenced this issue Sep 17, 2024
For #4086/#6491: address some warnings/future errors
93d95b3 
For #4086/#6491: use Scala 3 import wildcards
ebruchez pushed a commit that referenced this issue Sep 17, 2024
For #4086/#6491: remove BeanProperty
61ce123
ebruchez pushed a commit that referenced this issue Sep 17, 2024
For #4086/#6491: remove do...while
6d959a2
ebruchez pushed a commit that referenced this issue Sep 17, 2024
For #4086/#6491: warnings and future features
11fe157
ebruchez pushed a commit that referenced this issue Sep 17, 2024
For #4086/#6491: comment out non-working code
4c60bbd
ebruchez pushed a commit that referenced this issue Sep 17, 2024
For #6491: compile dom module with Scala 3
3c5a625
ebruchez pushed a commit that referenced this issue Sep 17, 2024
For #4086/#6491: update syntax
86ed969
ebruchez pushed a commit that referenced this issue Sep 17, 2024
For #4086/#6491: update varargs syntax
888c2f0
ebruchez pushed a commit that referenced this issue Sep 17, 2024
For #4086/#6491: use as in imports
7a5b345
ebruchez pushed a commit that referenced this issue Sep 17, 2024
For #4086/#6491: use & instead of with
900d706
ebruchez pushed a commit that referenced this issue Sep 17, 2024
For #4086/#6491: fixes for update varargs syntax
329c5f6
@obruchez
Copy link
Collaborator

The incorrect warning unused value of type scala.xml.NodeBuffer (add : Unit to discard silently) is a bug in the compiler: scala/bug#12658

ebruchez pushed a commit that referenced this issue Sep 18, 2024
For #4086/#6491: more * for imports
e6ce78c
ebruchez pushed a commit that referenced this issue Sep 18, 2024
For #4086/#6491: update syntax
813d513
ebruchez pushed a commit that referenced this issue Sep 18, 2024
For #4086/#6491: future fix for match
bc58a8e
ebruchez pushed a commit that referenced this issue Sep 18, 2024
For #4086/#6491: warnings, comments
dff905a
ebruchez pushed a commit that referenced this issue Sep 18, 2024
For #6491: update ProGuard build
9c22c4e
ebruchez pushed a commit that referenced this issue Sep 18, 2024
For #6491: module xforms-filter uses Scala 3
22f1dc6
@ebruchez
Copy link
Collaborator Author

Started using Scala 3 in a few modules. I have encountered issues, and given up for now, with some modules:

  • orbeon-proxy-portlet: issue with the scala-xml dependency
  • orbeon-servlet-support: can't find implementations for trait RequestRemoveHeaders from Scala 2.13 users of that module

ebruchez pushed a commit that referenced this issue Sep 19, 2024
For #4086/#6491: warnings
d69a597
ebruchez pushed a commit that referenced this issue Sep 19, 2024
For #6491: compile authorizer module with Scala 3
fe116ef 
- also try Optional Braces syntax and Universal Apply Methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebruchez ebruchez

Labels
Area: Build
Projects
Orbeon Forms 2024.1
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ebruchez @obruchez