-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Division by 0 issue - Problem with running geoclimate on Nice #863
Comments
Thanks. Investigation under the pipe |
@balglave can you share your log file to see exactly where the error is located ? |
Here it is:
|
Youps, sorry for not responding, I completely missed your comment... |
No worries. The problem comes from the UTRF distribution calculated based on floor area. Normally, if there is no building in a RSU, it is not considered in the distribution calculation. This is OK for the UTRF distribution based on building fraction. However, when the UTRF distribution is based on floor area fraction, it does not work if all buildings in the RSU have a floor area equal to 0, which is the case for a RSU in Nice... We have two buildings (ID_SOURCE w448862514 and w141719740) within a single RSU having building height = 2 m. Thus, due to the floor area calculation method, the floor area results in 0 m². We have 3 options to solve that:
I would opt for the second solution. @ebocher what do you think ? |
+1 for second solution |
The problem comes from the nb_lev formatting in the OSM workflow. The BDTopo formatting seems OK (the max of heightRoof / h_lev_min and 1 is taken). Here is a bbox test for the building causing the troubles: |
OK the problem is more complex than expected. I could perform the test for a building having a height lower than 3 m, the building is not even considered if this height information comes alone (ejected from this line). However, if this information does not come alone as this is the case for building w141719740, thus the building is considered as it also have a nb_lev = 1. However, the nb_lev is downgraded to 0 but not in the initial formatting step. I suspect that it is when there is the building height estimation (I am investigating). Anyway, there is a first inconsistency in our method: we consider a building as OK if it has a nb_lev > 0 but a building height < 3 m while we consider a building having only a building height < 3 m is not a building (it is evinced). I suggest we keep it and put its nb_lev to 1 (it is the case for BDTopo). |
Fixed thanks @j3r3m1 |
Hi,
I want to run GeoClimate on Nice, but I am having a "division by 0" issue.
The request is below. Does someone have an idea where could be the problem ?
Thanks ! :)
Baptiste
The text was updated successfully, but these errors were encountered: