Update to integrate JOSS review from @arbennett #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR intregates some changes : 1. Replace 2.5 geometries by 2D geometries. Wall and roof values are attributes to the spatial feature. 2. Clarify Block scale definition 2. Clarify RSU definition
ebocher
requested review from
ELSW56,
franetibe,
gpetit,
j3r3m1 and
SPalominos
j3r3m1
reviewed
Sep 14, 2021
| 3. Reference Spatial Unit (RSU) scale, being the elementary unit to characterize all the characteristics of a piece of land (not only related to buildings but also to vegetation, water). | ||
| 1. Building scale, defined as a collection of features represented by 2D geometries with attributes as measures for walls and roof. | ||
| 2. Block scale, defined as the union of the geometries of buildings touching each other (at least one point in common). Note that the union can represent a single building. | ||
| 3. Reference Spatial Unit (RSU) scale, being the elementary unit to characterize all the characteristics of a piece of land. The RSU are calculated according to several geographic informations that describe the territory and could have an impact on the urban climate: the road and rail network as well as the vegetation area and water surfaces (when they are sufficiently large to be considered as climatically important – default values are respectively 100’000 m² and 2’500 m²). | ||
|
|
There was a problem hiding this comment.
should we add a figure for blocks or / and at least RSU ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intregates some changes :