OSM workflow restructuring #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve data processing perfs
…in a continous domain when the location is represented by a set of polygons e.g islands
j3r3m1
reviewed
Sep 28, 2022
| @@ -162,8 +162,8 @@ IProcess neighborsProperties() { | |||
| } | |||
| query += """$ID_FIELD FROM ( | |||
| SELECT | |||
| ST_INTERSECTION(a.$GEOMETRIC_FIELD, | |||
| b.$GEOMETRIC_FIELD) AS the_geom, | |||
| ST_INTERSECTION(st_makevalid(a.$GEOMETRIC_FIELD), | |||
There was a problem hiding this comment.
Shouldn't they made valid before ? We will be back to put makevalid everywhere otherwise no ?
There was a problem hiding this comment.
In therory yes, but I don't know why. If I remove the st_valid we have a topology exception
…ve multipolygons. So we check only the dimension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces improvements on OSM module :