Reorganize module WorkflowGeoIndicators.groovy #787
Conversation
|
Remains two main steps which are:
Then an other PR would be to leave the possibility to skip the spatial unit creation if the user wants to use its own RSU. |
|
@ebocher an error is obtained in the test called runBDTopoWorkflowWithSRID(). It seems the parameter snappingDistance passed to the workflow computeAllGeoindicators is null at this stage. I would have expected that in that case the default value for snappingDistance in the workflow computeAllGeoindicators() is taken by default (0.01) but it is not the case, the value is kept as null which cause SQL issue afterward. What would be the best solution to solve that ? As a simple fix I can modify (add) the value of snappingDistance in the test but you might have a more generic way to solve it ? |
|
|
||
|
|
||
| /** | ||
| * Compute the typology indicators |
There was a problem hiding this comment.
TEB is not a typology indicators. What about computeRSUIndicators
There was a problem hiding this comment.
This part of the code does not include anything concerning TEB. computeRSUIndicators is not performed here, only typology classifications (UTRF and LCZ) are computed here (based on geoindicators tables)
| } | ||
|
|
||
| //The spatial relation tables RSU and BLOCK must be filtered to keep only necessary columns | ||
| def rsuRelationFiltered = prefix prefixName, "RSU_RELATION_" |
There was a problem hiding this comment.
Not sure to understand this filter
There was a problem hiding this comment.
rsuRelationFiltered used intead of rsuTable
If yes is rsuTable deleted ?
There was a problem hiding this comment.
This part of the code was already existing in the previous version. Not sure what contains rsuTable but it might be useless. Yes rsuTable is deleted.
This PR will reorganize the module WorkflowGeoIndicators in order to simplify the use of individual workflows in the future and to facilitate the use of own RSU by users.