Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit focus_lost event, add events.FOCUS_LOST #2

Closed
wants to merge 1 commit into from

Conversation

brainrake
Copy link

Expose focus_lost event to lua. A handler was already registered in gtk, so this is a small change.
This change enables autosave on focus lost, a convenient, previously requested feature.

@orbitalquark
Copy link
Owner

orbitalquark commented Nov 15, 2020 via email

@orbitalquark orbitalquark added the enhancement New feature or request label Nov 15, 2020
@brainrake
Copy link
Author

Thanks, I wasn't sure about the order.
Seems to be working fine. There is one possible quirk: focus lost event is emitted when dialogs are opened (save, command chooser, etc). I find this behavior acceptable, just wanted to note it.

@orbitalquark
Copy link
Owner

orbitalquark commented Nov 16, 2020 via email

@orbitalquark
Copy link
Owner

orbitalquark commented Nov 16, 2020 via email

@orbitalquark
Copy link
Owner

orbitalquark commented Nov 17, 2020 via email

@brainrake brainrake deleted the focus-lost branch November 17, 2020 01:49
@brainrake
Copy link
Author

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants