Skip to content
This repository has been archived by the owner on Sep 30, 2023. It is now read-only.

Update js-ipfs 0.37.x #266

Closed
wants to merge 2 commits into from
Closed

Update js-ipfs 0.37.x #266

wants to merge 2 commits into from

Conversation

aphelionz
Copy link
Contributor

@aphelionz aphelionz commented Sep 5, 2019

Description (Required)

This PR ensures compatibility with js-ipfs@^0.37.0

TODO

  • Fix replication test in go-ipfs

@aphelionz aphelionz added the WIP label Sep 5, 2019
@aphelionz
Copy link
Contributor Author

@alanshaw Might you be able to take a look at the test failure here and provide insight into why the pubsub messages via js-ipfs-http-api are failing after 92 messages sent?

CircleCI (not sure if you can see it) https://circleci.com/gh/orbitdb/ipfs-log/1410

But here you can see it passes with js-ipfs and fails with go-ipfs via HTTP API

Screenshot from 2019-09-05 13-50-17

Here's the test code: https://github.com/orbitdb/ipfs-log/blob/fix/js-ipfs0.37.0/test/replicate.spec.js#L120

@alanshaw
Copy link

alanshaw commented Sep 5, 2019

What version of js-ipfs-http-client are you using?

@aphelionz
Copy link
Contributor Author

Interesting, looks like it could be a version mismatch between ipfsd-ctl and js-ipfs

Screenshot from 2019-09-05 18-50-32

@aphelionz
Copy link
Contributor Author

Though, I tried installing both explicitly and they both had the same result :(

@alanshaw
Copy link

alanshaw commented Sep 5, 2019

Is the JS daemon in process or external?

@alanshaw
Copy link

alanshaw commented Sep 5, 2019

In v34 we switched the pubsub implementation to use the fetch API (node-fetch in Node.js) so this could be a new bug.

@aphelionz
Copy link
Contributor Author

@alanshaw In process. It's included via ipfsd-ctl as part of https://github.com/orbitdb/orbit-db-test-utils

@alanshaw
Copy link

alanshaw commented Sep 6, 2019

Can you try ipfsd-ctl@0.45.1? In 0.46 it no longer passes the --enable-pubsub-experiment flag (pubsub will be enabled by default in js-ipfs 0.38 and the next go-ipfs release ipfs/kubo#6621)

@alanshaw
Copy link

I encountered this yesterday and thought there's a possibility this issue could be due to it sindresorhus/ky-universal#8

There's a workaround coming in ipfs-inactive/js-ipfs-http-client#1101

If changing ipfsd-ctl version doesn't work it would be helpful if you were able to test out that branch?

@aphelionz aphelionz closed this Sep 27, 2019
@aphelionz aphelionz deleted the fix/js-ipfs0.37.0 branch May 11, 2020 16:54
@aphelionz aphelionz restored the fix/js-ipfs0.37.0 branch May 11, 2020 16:54
@aphelionz aphelionz deleted the fix/js-ipfs0.37.0 branch May 11, 2020 16:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants