This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Added an exit button for the Settings view #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a button on the ChannelHeader to go back to the last visited channel. TODO: Change the exit button's icon
|
This looks great! There are a few indentation / formatting issues. Would you mind fixing those? |
|
Sorry about that. Will do. |
Changed tabbed-indents to 2-spaced-indents.
|
Fixed Indentation Issues. |
JaniAnttonen
suggested changes
Nov 18, 2019
| @@ -19,6 +19,7 @@ const MessageUserProfilePanel = lazy(() => | |||
| function ChannelView () { | |||
| const { networkStore } = useContext(RootContext) | |||
| const { channel } = useParams() | |||
| window.lastChannel = (channel == undefined) ? window.lastChannel : channel | |||
There was a problem hiding this comment.
Instead of using window I'd recommend using useHistory from react-router-dom OR using a store from context, just to keep the application state in order.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an exit-button to the right side of the ChannelHeader for the SettingsView. This solves Issue #122.