Ember 1.13 #75
Merged
Ember 1.13 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,15 +1,12 @@ | |||
| import Schema from 'ember-orbit/schema'; | |||
| import Store from 'ember-orbit/store'; | |||
|
|
|||
| var get = Ember.get, | |||
| set = Ember.set; | |||
|
|
|||
| var createStore = function(options) { | |||
| options = options || {}; | |||
|
|
|||
| var container = new Ember.Container(); | |||
There was a problem hiding this comment.
Someone more familiar with the changes here in 1.13 should rewrite this to not print deprecations... @dgeb ?
There was a problem hiding this comment.
I'm hoping to clean up the registry / container mess in ember itself with emberjs/ember.js#11440
Since that's not yet merged, I'll try to clean up any remaining deprecations for 1.13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #69 and builds on top adding
Ember.EXTEND_PROTOTYPES = false;and updates bower stuff to be Ember 1.13.0