Skip to content

Commit

Permalink
revert(graph): remove useless drop shadow
Browse files Browse the repository at this point in the history
  • Loading branch information
orblazer committed Dec 5, 2021
1 parent 45820d3 commit 561c1e6
Show file tree
Hide file tree
Showing 9 changed files with 3 additions and 37 deletions.
3 changes: 0 additions & 3 deletions package/contents/config/main.xml
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@
<entry name="sampleCount" type="Int">
<default>10</default>
</entry>
<entry name="enableShadows" type="Bool">
<default>true</default>
</entry>
<entry name="fontScale" type="Int">
<default>26</default>
</entry>
Expand Down
Binary file not shown.
Binary file not shown.
13 changes: 0 additions & 13 deletions package/contents/ui/components/SensorGraph.qml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import QtQuick 2.2
import QtGraphicalEffects 1.0
import org.kde.plasma.plasmoid 2.0
import org.kde.plasma.components 2.0 as PlasmaComponents

Expand Down Expand Up @@ -27,7 +26,6 @@ Item {
property color secondLabelColor: theme.textColor
property bool secondLabelWhenZero: true

property bool enableShadows: plasmoid.configuration.enableShadows
property string placement: plasmoid.configuration.placement // Values: top-right, top-left, bottom-right, bottom-left
property string displayment: plasmoid.configuration.displayment // Values: always, hover, hover-hints

Expand Down Expand Up @@ -237,17 +235,6 @@ Item {
}
]
}

DropShadow {
visible: enableShadows
anchors.fill: textContainer
radius: 3
samples: 8
spread: 0.8
fast: true
color: theme.backgroundColor
source: textContainer
}
}

onDisplaymentChanged: {
Expand Down
6 changes: 0 additions & 6 deletions package/contents/ui/config/ConfigAppearance.qml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ QtLayouts.ColumnLayout {
property alias cfg_graphMargin: graphMargin.value
property alias cfg_graphFillOpacity: graphFillOpacity.value

property alias cfg_enableShadows: enableShadows.checked
property alias cfg_fontScale: fontScale.value
property string cfg_placement: ""
property string cfg_displayment: ""
Expand Down Expand Up @@ -121,11 +120,6 @@ QtLayouts.ColumnLayout {
id: textPage
wideMode: true

QtControls.CheckBox {
id: enableShadows
text: i18n("Drop shadows")
}

RMControls.SpinBox {
id: fontScale
Kirigami.FormData.label: i18n("Font scale:")
Expand Down
6 changes: 3 additions & 3 deletions package/translate/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ Or if you know how to make a pull request

| Locale | Lines | % Done|
|----------|---------|-------|
| Template | 69 | |
| fr | 69/69 | 100% |
| nl | 69/69 | 100% |
| Template | 68 | |
| fr | 68/68 | 100% |
| nl | 68/68 | 100% |
4 changes: 0 additions & 4 deletions package/translate/fr.po
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,6 @@ msgstr "Marge :"
msgid "Fill opacity:"
msgstr "Opacité du remplissage :"

#: ../contents/ui/config/ConfigAppearance.qml:126
msgid "Drop shadows"
msgstr "Ombres portées"

#: ../contents/ui/config/ConfigAppearance.qml:131
msgid "Font scale:"
msgstr "Taille de la police :"
Expand Down
4 changes: 0 additions & 4 deletions package/translate/nl.po
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,6 @@ msgstr "Marge:"
msgid "Fill opacity:"
msgstr "Ondoorzichtigheid vullen:"

#: ../contents/ui/config/ConfigAppearance.qml:126
msgid "Drop shadows"
msgstr "Vallende schaduwen"

#: ../contents/ui/config/ConfigAppearance.qml:131
msgid "Font scale:"
msgstr "Tekstgrootte:"
Expand Down
4 changes: 0 additions & 4 deletions package/translate/template.pot
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,6 @@ msgstr ""
msgid "Fill opacity:"
msgstr ""

#: ../contents/ui/config/ConfigAppearance.qml:126
msgid "Drop shadows"
msgstr ""

#: ../contents/ui/config/ConfigAppearance.qml:131
msgid "Font scale:"
msgstr ""
Expand Down

0 comments on commit 561c1e6

Please sign in to comment.