Rename fetchWhirlpools to fetchWhirlpoolsByTokenPair
#456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjthieme
changed the title
fetchWhirlpools to fetchWhirlPoolsByTokenPairfetchWhirlpools to fetchWhirlpoolsByTokenPair
yugure-orca
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the ts-sdk PR I remember there were a couple of comments about this but turns out I never actually ended up changing it. Theoretically this is now a breaking change since the ts-sdk has been deployed but I think this is semi-fine given that it has only been deployed for a week.
The issue with the
fetchWhirlpoolsname is that it conflicts withfetchWhirlpoolandfetchAllWhirlpoolsfrom whirlpools-client.