Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove liq param from ClosePosition function #473

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

wjthieme
Copy link
Member

@wjthieme wjthieme commented Nov 6, 2024

Since you have to fully empty the position on closing it makes no sense to allow the user to specify how much liquidity they would like to withdraw.

@wjthieme wjthieme self-assigned this Nov 6, 2024
@wjthieme wjthieme enabled auto-merge (squash) November 7, 2024 22:55
@wjthieme wjthieme merged commit 81d64fe into main Nov 7, 2024
5 checks passed
@wjthieme wjthieme deleted the wjthieme/close-position-fix branch November 7, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants