Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve calculating index in tick array #474

Merged
merged 5 commits into from
Nov 7, 2024
Merged

Improve calculating index in tick array #474

merged 5 commits into from
Nov 7, 2024

Conversation

wjthieme
Copy link
Member

@wjthieme wjthieme commented Nov 6, 2024 •
edited
Loading

Couple issues

  1. No tests for this function
  2. Think it handled negative tick indexes correctly (negative number minus a larger negative number = positive) but made it more explicit
  3. Undefined behaviour if a tick index outside of a tick array was specified

@wjthieme wjthieme self-assigned this Nov 6, 2024
@wjthieme wjthieme changed the title Fix a bug calculating index in tick array Improve calculating index in tick array Nov 6, 2024
@wjthieme wjthieme merged commit 7c6b988 into main Nov 7, 2024
5 checks passed
@wjthieme wjthieme deleted the wjthieme/core-bug branch November 7, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odcheung odcheung odcheung approved these changes

@yugure-orca yugure-orca Awaiting requested review from yugure-orca yugure-orca is a code owner

Assignees

@wjthieme wjthieme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjthieme @odcheung