Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvement to fetchPositionsForOwner #491

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Small improvement to fetchPositionsForOwner #491

merged 1 commit into from
Nov 12, 2024

Conversation

wjthieme
Copy link
Member

Internally we used the property owner to store the tokenProgram in a Token object. This might create confusion since Token already has owner which is the owner of the token account.

Externally this doesn't change anything since the Token object is not returned by the function.

@wjthieme wjthieme self-assigned this Nov 11, 2024
yugure-orca
yugure-orca approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@yugure-orca yugure-orca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjthieme wjthieme merged commit c83c498 into main Nov 12, 2024
6 checks passed
@wjthieme wjthieme deleted the wjthieme/improve-fetch-positions branch November 12, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yugure-orca yugure-orca yugure-orca approved these changes

@odcheung odcheung Awaiting requested review from odcheung odcheung is a code owner

Assignees

@wjthieme wjthieme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjthieme @yugure-orca