Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Orca team,
I found a potential overflow when I was trying to calculate quote for SOL -> USDC using
orca_whirlpools_core
in debug mode.More specifically,
next_start_tick_index
might bei32::MAX
andcurrent_start_tick_index
might be negative value like-13728
, Rust would panic with error:attempt to subtract with overflow
This fix uses short-circuit evaluation to work around this check, maybe a more explicit fix is to convert
next_start_tick_index
toi64
?