Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tally DX Survey #570

Merged
merged 9 commits into from
Dec 7, 2024
Merged

Add Tally DX Survey #570

merged 9 commits into from
Dec 7, 2024

Conversation

calintje
Copy link
Contributor

@calintje calintje commented Dec 4, 2024

Title
Add Tally DX Survey To Docs Site

Details

  • Added animated button
  • Survey opens on button click
  • The survey hides on submit

Screenshot 2024-12-07 054935

Screenshot 2024-12-04 233604

@wjthieme
Copy link
Member

wjthieme commented Dec 5, 2024

Maybe opening on page load is a little too agressive. Can we add a button in the nav bar 'GIVE FEEDBACK' or something like that that always opens the survey?

Copy link
Member

@wjthieme wjthieme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


useEffect(() => {
const script = document.createElement("script");
script.src = "https://tally.so/widgets/embed.js";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be safer to just use a next <Script> tag (https://nextjs.org/docs/app/api-reference/components/script)

@calintje calintje enabled auto-merge (squash) December 7, 2024 21:01
@calintje calintje merged commit c944831 into main Dec 7, 2024
5 checks passed
@calintje calintje deleted the calintje/tally-survey branch December 7, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants