Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace force_text with force_str for django >= 3 #27

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vtemian
Copy link

@vtemian vtemian commented May 8, 2020

Closes #22.

Since Django 3.0, force_text helper was declared deprecated.

From its definition, it seems that will be replaced with force_str
https://docs.djangoproject.com/en/3.0/_modules/django/utils/encoding/#force_text

@coveralls
Copy link

coveralls commented May 8, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling f117134 on vtemian:force-text-deprication into 8f8cadb on orcasgit:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 69a77ec on vtemian:force-text-deprication into 8f8cadb on orcasgit:master.

@ArtemBernatskyy
Copy link

@brad , any news when this will be merged/reviewed?
Thx!

@robd003
Copy link

robd003 commented Jan 4, 2021

Is this project dead? Any reason why this hasn't been merged in for over half a year?

@lociii
Copy link

lociii commented Apr 14, 2021

Would also really appreciate this change to get merged and released.
Less warnings, much better.

Unfortunately we're getting close to the first birthday of the PR :-(

@gl3nn
Copy link

gl3nn commented Jun 10, 2021

It would be nice if this could be merged and released! Or if someone can take this over and release a 0.7. @brad ?

@jpic
Copy link

jpic commented Dec 24, 2021

This is now necessary otherwise the package won't work with Django 4

@yourlabsopensource
Copy link

yourlabsopensource commented Dec 24, 2021

I'm maintaining a fork where I merged the pull requests and released 0.7.0 with Django 4.0 support.

https://yourlabs.io/oss/djfernet
https://github.com/yourlabs/djfernet
https://pypi.org/project/djfernet
https://djfernet.rtfd.io

Njoy
🎩

@galileoguzman
Copy link

galileoguzman commented Jan 18, 2022

Is there any new on this PR, Django 4 wont work until we get this merged.

@fjsj @grokcode @brad @hockeybuggy @owen-applico @cburza @AlexRiina

@hockeybuggy
Copy link
Contributor

Not that I am aware of. I don't have a commit bit for this and am no longer working in Django these days (not for any particular reason; no judgment implied).

Copy link

@jpic jpic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to this beautiful app! 🎩

@awais786
Copy link

Any plan to merge this PR and release a new version ?

@robd003
Copy link

robd003 commented May 27, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning for force_text() in fields.py