-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace force_text with force_str for django >= 3 #27
base: master
Are you sure you want to change the base?
Conversation
@brad , any news when this will be merged/reviewed? |
Is this project dead? Any reason why this hasn't been merged in for over half a year? |
Would also really appreciate this change to get merged and released. Unfortunately we're getting close to the first birthday of the PR :-( |
It would be nice if this could be merged and released! Or if someone can take this over and release a 0.7. @brad ? |
This is now necessary otherwise the package won't work with Django 4 |
I'm maintaining a fork where I merged the pull requests and released 0.7.0 with Django 4.0 support. https://yourlabs.io/oss/djfernet Njoy |
Is there any new on this PR, Django 4 wont work until we get this merged. @fjsj @grokcode @brad @hockeybuggy @owen-applico @cburza @AlexRiina |
Not that I am aware of. I don't have a commit bit for this and am no longer working in Django these days (not for any particular reason; no judgment implied). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing to this beautiful app! 🎩
Any plan to merge this PR and release a new version ? |
@awais786 Switch to this: https://github.com/yourlabs/djfernet |
Closes #22.
Since Django 3.0,
force_text
helper was declared deprecated.From its definition, it seems that will be replaced with
force_str
https://docs.djangoproject.com/en/3.0/_modules/django/utils/encoding/#force_text