Upgrade some dependencies #272
Conversation
Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
WalkthroughThe pull request updates three project files by upgrading their target framework from .NET 8.0 to .NET 9.0. In addition, it bumps several package versions: OrcanodeMonitor now uses the 9.0.0 version of Microsoft.VisualStudio.Web.CodeGeneration.Design, and the Test project receives updates to coverlet.collector, Microsoft.NET.Test.Sdk, MSTest.TestAdapter, and MSTest.TestFramework. The TransferData project file is updated solely for the framework version. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
OrcanodeMonitor/OrcanodeMonitor.csproj (1)
17-25:⚠️ Potential issueEnsure consistent package versions across all Microsoft packages.
There's a version mismatch between Microsoft packages:
- Microsoft.VisualStudio.Web.CodeGeneration.Design is on 9.0.0
- Other Microsoft packages (EntityFrameworkCore.*) are on 8.0.10
This could lead to compatibility issues. Please ensure all Microsoft packages are on the same major version (8.0.x).
- <PackageReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Design" Version="9.0.0" /> + <PackageReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Design" Version="8.0.6" />
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
OrcanodeMonitor/OrcanodeMonitor.csproj(2 hunks)Test/Test.csproj(2 hunks)TransferData/TransferData.csproj(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- TransferData/TransferData.csproj
🧰 Additional context used
🪛 GitHub Actions: CodeQL
OrcanodeMonitor/OrcanodeMonitor.csproj
[error] 166-166: The current .NET SDK does not support targeting .NET 9.0. Either target .NET 8.0 or lower, or use a version of the .NET SDK that supports .NET 9.0.
Test/Test.csproj
[error] 166-166: The current .NET SDK does not support targeting .NET 9.0. Either target .NET 8.0 or lower, or use a version of the .NET SDK that supports .NET 9.0.
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build_windows (Release)
- GitHub Check: build_windows (Debug)
🔇 Additional comments (1)
Test/Test.csproj (1)
13-16: Verify package version compatibility with .NET 8.0.Let's verify that the updated package versions are compatible with .NET 8.0.
✅ Verification successful
🌐 Web query:
What are the latest versions of coverlet.collector, Microsoft.NET.Test.Sdk, MSTest.TestAdapter, and MSTest.TestFramework that are compatible with .NET 8.0?💡 Result:
The latest compatible versions of these packages with .NET 8 are:
Coverlet.Collector
- Version: ≥6.0.x
- Requirements:
- Requires Microsoft.NET.Test.Sdk ≥17.5[1][6]
- Compatible with SDK v6+ (including .NET 8)[1]
- Sample configuration shows v6+ working with net48/net6+ targets[1]
Microsoft.NET.Test.Sdk
- Version: ≥17.8
- Critical requirement:
- For .NET 8 targeting:
- Minimum version 17.8 required[2]
- Version 17.9 required for SDK v8.0.400+[2]
MSTest Components
Package Version Key Compatibility TestAdapter ≥3.x (latest v3.7.x) Supports net8+ via dependencies[3][9] TestFramework ≥3.x (latest v3.7.x) Explicitly lists net8+ compatibility[8][9] Required configuration:
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9" /> <PackageReference Include="coverlet.collector" Version="6.x"> <PackageReference Include="MSTest.TestAdapter" Version="3.x" /> <PackageReference Include="MSTest.TestFramework" Version="3.x" />Note: These versions align with Microsoft's requirement that .NET SDK v8+ needs Visual Studio/MSBuild v17.9+ for full compatibility[2][9]. The MSTest SDK (v3.x) provides native support through its runner integration[5][7][9].
Citations:
- 1: https://www.nuget.org/packages/coverlet.collector
- 2: https://learn.microsoft.com/en-ie/dotnet/core/compatibility/sdk/8.0/version-requirements
- 3: https://www.nuget.org/packages/MSTest.TestAdapter/
- 4: https://www.nuget.org/packages/MSTest.TestFramework/2.2.8
- 5: https://learn.microsoft.com/en-us/dotnet/core/testing/unit-testing-mstest-runner-intro
- 6: https://github.com/coverlet-coverage/coverlet
- 7: https://learn.microsoft.com/en-us/dotnet/core/testing/unit-testing-mstest-sdk
- 8: https://www.nuget.org/packages/MSTest.TestFramework
- 9: https://devblogs.microsoft.com/dotnet/introducing-mstest-sdk/
- 10: https://www.lambdatest.com/blog/mstest-tutorial-environment-setup-for-selenium-testing/
Package version compatibility check
- coverlet.collector (6.0.4): This version falls within the 6.x range and is compatible with .NET 8.
- Microsoft.NET.Test.Sdk (17.13.0): This exceeds the minimum required version of 17.9 for .NET 8.
- MSTest.TestAdapter (3.8.0) and MSTest.TestFramework (3.8.0): Both being in the 3.x range meet the compatibility requirements for .NET 8.
The current configuration in the file aligns with the compatibility requirements for .NET 8 testing. No further changes are necessary.
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>net8.0</TargetFramework> | |||
| <TargetFramework>net9.0</TargetFramework> | |||
There was a problem hiding this comment.
Revert to .NET 8.0 as .NET 9.0 is not yet supported.
The pipeline is failing because .NET 9.0 is not yet supported by the current .NET SDK. Please revert to .NET 8.0.
- <TargetFramework>net9.0</TargetFramework>
+ <TargetFramework>net8.0</TargetFramework>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <TargetFramework>net9.0</TargetFramework> | |
| <TargetFramework>net8.0</TargetFramework> |
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk.Web"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>net8.0</TargetFramework> | |||
| <TargetFramework>net9.0</TargetFramework> | |||
There was a problem hiding this comment.
Revert to .NET 8.0 as .NET 9.0 is not yet supported.
The pipeline is failing because .NET 9.0 is not yet supported by the current .NET SDK. Please revert to .NET 8.0.
- <TargetFramework>net9.0</TargetFramework>
+ <TargetFramework>net8.0</TargetFramework>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <TargetFramework>net9.0</TargetFramework> | |
| <TargetFramework>net8.0</TargetFramework> |
Upgrade to .NET 9.0
Summary by CodeRabbit