-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ios target #148
Add Ios target #148
Conversation
Had to upgrade Okio
@@ -6,6 +6,6 @@ | |||
object Versions { | |||
const val KOTLIN = "1.6.21" | |||
const val JUNIT = "5.7.1" | |||
const val OKIO = "3.0.0" | |||
const val OKIO = "3.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This added the iOS common target
append(Char.MIN_LOW_SURROGATE + (codePoint and 0x3ff)) | ||
} | ||
else -> throw IllegalArgumentException() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copied this code from the linux version, is there anything platform specific needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I do not even think that this method is really a cross-platform code and cannot be in common :)
I will make a release after #145 I will add all other platforms this week |
@@ -0,0 +1,11 @@ | |||
package com.akuleshov7.ktoml.utils |
Check failure
Code scanning / ktlint
[HEADER_MISSING_IN_NON_SINGLE_CLASS_FILE] files that contain multiple or no classes should contain description of what is inside of this file: there are 0 declared classes and/or objects (cannot be auto-corrected)
ktoml-core/src/iosMain/kotlin/com/akuleshov7/ktoml/utils/UtilsIos.kt
Outdated
Show resolved
Hide resolved
* Specific implementation for utilities | ||
*/ | ||
|
||
package com.akuleshov7.ktoml.utils |
Check notice
Code scanning
[PACKAGE_NAME_INCORRECT_PATH] package name does not match the directory hierarchy for this file, the real package name should be: com.akuleshov7.macosArm64Main.kotlin.com.akuleshov7.ktoml.utils
* File utils to read files using okio | ||
*/ | ||
|
||
package com.akuleshov7.ktoml.file |
Check notice
Code scanning
[PACKAGE_NAME_INCORRECT_PATH] package name does not match the directory hierarchy for this file, the real package name should be: com.akuleshov7.macosArm64Main.kotlin.com.akuleshov7.ktoml.file
ktoml-core/src/macosArm64Main/kotlin/com/akuleshov7/ktoml/utils/UtilsMacM1.kt
Fixed
Show fixed
Hide fixed
@@ -0,0 +1,17 @@ | |||
@file:Suppress("PACKAGE_NAME_INCORRECT_PATH") | |||
|
|||
/** |
Check notice
Code scanning
[FILE_INCORRECT_BLOCKS_ORDER] general structure of kotlin source file is wrong, parts are in incorrect order: /**
ktoml-file/src/macosArm64Main/kotlin/com/akuleshov7/ktoml/file/FileUtilsMacM1.kt
Fixed
Show fixed
Hide fixed
@@ -0,0 +1,16 @@ | |||
@file:Suppress("PACKAGE_NAME_INCORRECT_PATH") | |||
|
|||
/** |
Check notice
Code scanning
[FILE_INCORRECT_BLOCKS_ORDER] general structure of kotlin source file is wrong, parts are in incorrect order: /**
235cf36
to
0cbf1c2
Compare
@Wavesonics thank you for your contribution, merged |
Wow thanks for fixing up those issues! |
Adds an iOS meta target,
I'm not sure if there is more to be done on the publishing side? But this compiles for me.