Classes that inherit sealed class should not be in a one file anymore #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: - separated tree node classes
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
ktlint found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
|
@NightEule5 I just split children of sealed classes (we can do it with new Kotlin) to make the file structure more obvious |
nulls
reviewed
Nov 11, 2022
| '\'' -> if (this.startsWith("'''")) { | ||
| // TomlMultilineString(this, lineNo) |
There was a problem hiding this comment.
thank you 🙏 @nulls , fixed and added comment
soon we will support multiline strings and it will be removed
nulls
approved these changes
Nov 11, 2022
### What's done: - separated tree node classes
### What's done: - separated tree node classes
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done: