Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle multi-line array #166

Merged
merged 4 commits into from
Dec 23, 2022
Merged

Handle multi-line array #166

merged 4 commits into from
Dec 23, 2022

Conversation

BOOMeranGG
Copy link
Collaborator

@BOOMeranGG BOOMeranGG commented Dec 4, 2022 •
edited
Loading

Fix #126

Hello! And thanks for your library! I love Kotlin and I like KTOML format. But I have never done any parsers before. So, I hope you will be patient with me :)

My idea is to merge multiline values into a single line and then process it as usually. If I missed something or this code needs improvement - I am ready.

@BOOMeranGG BOOMeranGG changed the title Handle multi-line array. #126 Handle multi-line array Dec 4, 2022
@Ifropc
Copy link

Ifropc commented Dec 6, 2022

Thank you very much for this PR! This bug is very annoying and prevents us to use this library in our project. (as soon as I tried to parse example toml from our tests I encountered it...)
I know you are busy, but could you please take a look on it @akuleshov7 @NightEule5 ? 0.3.1 with this fix would also be appreciated!

orchestr7
orchestr7 approved these changes Dec 6, 2022
View reviewed changes
Copy link
Owner

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, looks very easy! thank you so much

@BOOMeranGG
Copy link
Collaborator Author

Wait, I found a little bug. I'm gonna fix it soon

@BOOMeranGG BOOMeranGG mentioned this pull request Dec 7, 2022
Closed
@orchestr7
Copy link
Owner

pls also don't forget to add yourself to acknowledgements in readme :)

@orchestr7
Copy link
Owner

Thank you very much for this PR! This bug is very annoying and prevents us to use this library in our project. (as soon as I tried to parse example toml from our tests I encountered it...) I know you are busy, but could you please take a look on it @akuleshov7 @NightEule5 ? 0.3.1 with this fix would also be appreciated!

It's not yet easy, as soon as we will merge this PR, we will make a release... 😄

@BOOMeranGG
Copy link
Collaborator Author

@akuleshov7 Done

@0x6675636b796f75676974687562 0x6675636b796f75676974687562 mentioned this pull request Dec 23, 2022
Closed
@orchestr7 orchestr7 merged commit e6bd601 into orchestr7:main Dec 23, 2022
@orchestr7
Copy link
Owner

@akuleshov7 Done

thank you, you are awesome!

@BOOMeranGG BOOMeranGG deleted the multiline-arrays branch December 23, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orchestr7 orchestr7 orchestr7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-line array recurses infinitely
3 participants
@BOOMeranGG @Ifropc @orchestr7